net: ethernet: ixp4xx: Fix return value check in ixp4xx_eth_probe()

In case of error, the function mdiobus_get_phy() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c
index cb89323855d84f6d79ab1c6e297572cc992a05d1..1ecceeb9700dbc81dd3fe70516a8c2d1b60b8cba 100644 (file)
--- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
+++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
@@ -1531,8 +1531,8 @@ static int ixp4xx_eth_probe(struct platform_device *pdev)
                phydev = of_phy_get_and_connect(ndev, np, ixp4xx_adjust_link);
        } else {
                phydev = mdiobus_get_phy(mdio_bus, plat->phy);
-               if (IS_ERR(phydev)) {
-                       err = PTR_ERR(phydev);
+               if (!phydev) {
+                       err = -ENODEV;
                        dev_err(dev, "could not connect phydev (%d)\n", err);
                        goto err_free_mem;
                }