mtip32xx: prefer pcie_capability_read_word()
authorBjorn Helgaas <bhelgaas@google.com>
Tue, 26 Jan 2021 20:04:33 +0000 (14:04 -0600)
committerJens Axboe <axboe@kernel.dk>
Tue, 26 Jan 2021 20:09:39 +0000 (13:09 -0700)
Replace pci_read_config_word() with pcie_capability_read_word().

pcie_capability_read_word() takes care of a few special cases when reading
the PCIe capability.  See 8c0d3a02c130 ("PCI: Add accessors for PCI Express
Capability").

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/mtip32xx/mtip32xx.c

index b58f3a59b5bbb57a96599fcd182457d920751213..3be0dbc674bd0a120ec6ffeb16b4e97b52c11b80 100644 (file)
@@ -3924,14 +3924,10 @@ static DEFINE_HANDLER(7);
 
 static void mtip_disable_link_opts(struct driver_data *dd, struct pci_dev *pdev)
 {
-       int pos;
        unsigned short pcie_dev_ctrl;
 
-       pos = pci_find_capability(pdev, PCI_CAP_ID_EXP);
-       if (pos) {
-               pci_read_config_word(pdev,
-                       pos + PCI_EXP_DEVCTL,
-                       &pcie_dev_ctrl);
+       if (pci_is_pcie(pdev)) {
+               pcie_capability_read_word(pdev, PCI_EXP_DEVCTL, &pcie_dev_ctrl);
                if (pcie_dev_ctrl & PCI_EXP_DEVCTL_NOSNOOP_EN ||
                    pcie_dev_ctrl & PCI_EXP_DEVCTL_RELAX_EN) {
                        dev_info(&dd->pdev->dev,
@@ -3939,8 +3935,7 @@ static void mtip_disable_link_opts(struct driver_data *dd, struct pci_dev *pdev)
                                        pdev->vendor, pdev->device);
                        pcie_dev_ctrl &= ~(PCI_EXP_DEVCTL_NOSNOOP_EN |
                                                PCI_EXP_DEVCTL_RELAX_EN);
-                       pci_write_config_word(pdev,
-                               pos + PCI_EXP_DEVCTL,
+                       pcie_capability_write_word(pdev, PCI_EXP_DEVCTL,
                                pcie_dev_ctrl);
                }
        }