arm64: dts: qcom: apq8016-sbc: correct GPIO LEDs node names
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 14 Mar 2024 11:26:57 +0000 (12:26 +0100)
committerBjorn Andersson <andersson@kernel.org>
Wed, 3 Apr 2024 18:49:49 +0000 (13:49 -0500)
Individual LEDs in a GPIO LEDs device node are not addressable, thus
unit address is not correct.

dtc is also not happy:

  Warning (unit_address_vs_reg): /leds/led@5: node has a unit name, but no reg or ranges property

Reported-by: Sumit Garg <sumit.garg@linaro.org>
Closes: https://lore.kernel.org/all/CAFA6WYNRwF7GqhBk2B7i-deT3aLxNQckhnOasjip2TYm4HZgAw@mail.gmail.com/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20240314112657.167006-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/apq8016-sbc.dts

index 9ffad7d1f2b6cb9e700f7d3db7b29ac10b755b5b..aba08424aa38439952f959f79a9ded2201de1f7c 100644 (file)
@@ -91,7 +91,7 @@
 
                compatible = "gpio-leds";
 
-               led@1 {
+               led-1 {
                        label = "apq8016-sbc:green:user1";
                        function = LED_FUNCTION_HEARTBEAT;
                        color = <LED_COLOR_ID_GREEN>;
                        default-state = "off";
                };
 
-               led@2 {
+               led-2 {
                        label = "apq8016-sbc:green:user2";
                        function = LED_FUNCTION_DISK_ACTIVITY;
                        color = <LED_COLOR_ID_GREEN>;
                        default-state = "off";
                };
 
-               led@3 {
+               led-3 {
                        label = "apq8016-sbc:green:user3";
                        function = LED_FUNCTION_DISK_ACTIVITY;
                        color = <LED_COLOR_ID_GREEN>;
                        default-state = "off";
                };
 
-               led@4 {
+               led-4 {
                        label = "apq8016-sbc:green:user4";
                        color = <LED_COLOR_ID_GREEN>;
                        gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
                        default-state = "off";
                };
 
-               led@5 {
+               led-5 {
                        label = "apq8016-sbc:yellow:wlan";
                        function = LED_FUNCTION_WLAN;
                        color = <LED_COLOR_ID_YELLOW>;
                        default-state = "off";
                };
 
-               led@6 {
+               led-6 {
                        label = "apq8016-sbc:blue:bt";
                        function = LED_FUNCTION_BLUETOOTH;
                        color = <LED_COLOR_ID_BLUE>;