pinctrl: amd: Use devm_platform_get_and_ioremap_resource
authorBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Mon, 13 Jun 2022 06:41:25 +0000 (12:11 +0530)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 9 Jul 2022 23:09:21 +0000 (01:09 +0200)
Use devm_platform_get_and_ioremap_resource() to simplify code.

Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Link: https://lore.kernel.org/r/20220613064127.220416-2-Basavaraj.Natikar@amd.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-amd.c

index ed52ea6a1ed895c30ec54c0f9c276fb8acb7865a..e497df89a4a70d9c856403d3a699a3f9fdf121e4 100644 (file)
@@ -1079,17 +1079,12 @@ static int amd_gpio_probe(struct platform_device *pdev)
 
        raw_spin_lock_init(&gpio_dev->lock);
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res) {
+       gpio_dev->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
+       if (IS_ERR(gpio_dev->base)) {
                dev_err(&pdev->dev, "Failed to get gpio io resource.\n");
-               return -EINVAL;
+               return PTR_ERR(gpio_dev->base);
        }
 
-       gpio_dev->base = devm_ioremap(&pdev->dev, res->start,
-                                               resource_size(res));
-       if (!gpio_dev->base)
-               return -ENOMEM;
-
        gpio_dev->irq = platform_get_irq(pdev, 0);
        if (gpio_dev->irq < 0)
                return gpio_dev->irq;