media: mediatek: vpu: add missing clk_unprepare

If vpu_clock_enable() fails, then call clk_unprepare().

This fixes this smatch warning:

drivers/media/platform/mediatek/vpu/mtk_vpu.c:1031 mtk_vpu_resume() warn: 'vpu->clk' from clk_prepare() not released on lines: 1020.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Yunfei Dong <yunfei.dong@mediatek.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/platform/mediatek/vpu/mtk_vpu.c b/drivers/media/platform/mediatek/vpu/mtk_vpu.c
index 1a95958a1f908595bdb5faa5eb7c3e1bc77df45f..4c8f5296d120eecaa24d570896c06910a66fb10e 100644 (file)
--- a/drivers/media/platform/mediatek/vpu/mtk_vpu.c
+++ b/drivers/media/platform/mediatek/vpu/mtk_vpu.c
@@ -1018,6 +1018,7 @@ static int mtk_vpu_resume(struct device *dev)
        clk_prepare(vpu->clk);
        ret = vpu_clock_enable(vpu);
        if (ret) {
+               clk_unprepare(vpu->clk);
                dev_err(dev, "failed to enable vpu clock\n");
                return ret;
        }