include/qemu/host-utils.h: Simplify the compiler check in mulu128()
authorThomas Huth <thuth@redhat.com>
Thu, 21 Jul 2022 07:48:09 +0000 (09:48 +0200)
committerLaurent Vivier <laurent@vivier.eu>
Thu, 4 Aug 2022 11:49:47 +0000 (13:49 +0200)
We currently require at least GCC 7.4 or Clang 6.0 for compiling QEMU.
GCC has __builtin_mul_overflow since version 5 already, and Clang 6.0
also provides this built-in function (see its documentation on this page:
https://releases.llvm.org/6.0.0/tools/clang/docs/LanguageExtensions.html ).
So we can simplify the #if statement here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220721074809.1513357-1-thuth@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
include/qemu/host-utils.h

index 29f3a998788080fb2094168c6eda0d870da4a627..88d476161ccb4588984eaf60f231e2487f279e4e 100644 (file)
@@ -533,8 +533,7 @@ static inline bool umul64_overflow(uint64_t x, uint64_t y, uint64_t *ret)
  */
 static inline bool mulu128(uint64_t *plow, uint64_t *phigh, uint64_t factor)
 {
-#if defined(CONFIG_INT128) && \
-    (__has_builtin(__builtin_mul_overflow) || __GNUC__ >= 5)
+#if defined(CONFIG_INT128)
     bool res;
     __uint128_t r;
     __uint128_t f = ((__uint128_t)*phigh << 64) | *plow;