soundwire: stream: constify sdw_port_config when adding devices
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 20 Nov 2023 17:47:20 +0000 (18:47 +0100)
committerVinod Koul <vkoul@kernel.org>
Thu, 23 Nov 2023 07:16:20 +0000 (12:46 +0530)
sdw_stream_add_master() and sdw_stream_add_slave() do not modify
contents of passed sdw_port_config, so it can be made const for code
safety and as documentation of expected usage.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20231120174720.239610-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/stream.c
include/linux/soundwire/sdw.h

index 69719b335bcb1e4c9427d6c5331b5f5597e96725..9dc6399f206afd0354352f9de5d69ce2e9440282 100644 (file)
@@ -897,7 +897,7 @@ static struct sdw_port_runtime *sdw_port_alloc(struct list_head *port_list)
 }
 
 static int sdw_port_config(struct sdw_port_runtime *p_rt,
-                          struct sdw_port_config *port_config,
+                          const struct sdw_port_config *port_config,
                           int port_index)
 {
        p_rt->ch_mask = port_config[port_index].ch_mask;
@@ -970,7 +970,7 @@ static int sdw_slave_port_is_valid_range(struct device *dev, int num)
 
 static int sdw_slave_port_config(struct sdw_slave *slave,
                                 struct sdw_slave_runtime *s_rt,
-                                struct sdw_port_config *port_config)
+                                const struct sdw_port_config *port_config)
 {
        struct sdw_port_runtime *p_rt;
        int ret;
@@ -1026,7 +1026,7 @@ static int sdw_master_port_alloc(struct sdw_master_runtime *m_rt,
 }
 
 static int sdw_master_port_config(struct sdw_master_runtime *m_rt,
-                                 struct sdw_port_config *port_config)
+                                 const struct sdw_port_config *port_config)
 {
        struct sdw_port_runtime *p_rt;
        int ret;
@@ -1861,7 +1861,7 @@ EXPORT_SYMBOL(sdw_release_stream);
  */
 int sdw_stream_add_master(struct sdw_bus *bus,
                          struct sdw_stream_config *stream_config,
-                         struct sdw_port_config *port_config,
+                         const struct sdw_port_config *port_config,
                          unsigned int num_ports,
                          struct sdw_stream_runtime *stream)
 {
@@ -1981,7 +1981,7 @@ EXPORT_SYMBOL(sdw_stream_remove_master);
  */
 int sdw_stream_add_slave(struct sdw_slave *slave,
                         struct sdw_stream_config *stream_config,
-                        struct sdw_port_config *port_config,
+                        const struct sdw_port_config *port_config,
                         unsigned int num_ports,
                         struct sdw_stream_runtime *stream)
 {
index 4f3d14bb15385a2860e4e1ee54738f60eb7c1b06..904004d8b562296fc2173e2b5ee371d5c85f27f7 100644 (file)
@@ -1040,7 +1040,7 @@ int sdw_compute_params(struct sdw_bus *bus);
 
 int sdw_stream_add_master(struct sdw_bus *bus,
                struct sdw_stream_config *stream_config,
-               struct sdw_port_config *port_config,
+               const struct sdw_port_config *port_config,
                unsigned int num_ports,
                struct sdw_stream_runtime *stream);
 int sdw_stream_remove_master(struct sdw_bus *bus,
@@ -1062,7 +1062,7 @@ void sdw_extract_slave_id(struct sdw_bus *bus, u64 addr, struct sdw_slave_id *id
 
 int sdw_stream_add_slave(struct sdw_slave *slave,
                         struct sdw_stream_config *stream_config,
-                        struct sdw_port_config *port_config,
+                        const struct sdw_port_config *port_config,
                         unsigned int num_ports,
                         struct sdw_stream_runtime *stream);
 int sdw_stream_remove_slave(struct sdw_slave *slave,
@@ -1084,7 +1084,7 @@ int sdw_update_no_pm(struct sdw_slave *slave, u32 addr, u8 mask, u8 val);
 
 static inline int sdw_stream_add_slave(struct sdw_slave *slave,
                                       struct sdw_stream_config *stream_config,
-                                      struct sdw_port_config *port_config,
+                                      const struct sdw_port_config *port_config,
                                       unsigned int num_ports,
                                       struct sdw_stream_runtime *stream)
 {