iio: imu: remove unused private data assigned with spi_set_drvdata()
authorAlexandru Ardelean <aardelean@deviqon.com>
Thu, 13 May 2021 12:25:12 +0000 (15:25 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 13 Jun 2021 16:00:17 +0000 (17:00 +0100)
These were usually used before the conversion to devm_ functions, so that
the remove hook would be able to retrieve the pointer and do cleanups on
remove.
When the conversion happened, they should have been removed, but were
omitted.

Some drivers were copied from drivers that fit the criteria described
above. In any case, in order to prevent more drivers from being used as
example (and have spi_set_drvdata() needlessly set), this change removes it
from the IIO IMU group.

Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
Link: https://lore.kernel.org/r/20210513122512.93187-1-aardelean@deviqon.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/adis16400.c
drivers/iio/imu/adis16460.c
drivers/iio/imu/adis16475.c
drivers/iio/imu/adis16480.c

index 641b4f7d066d86e2a2bccc883906254959784e4c..b12917a7cb60226a71c80604d7f0951c883214d3 100644 (file)
@@ -1157,8 +1157,6 @@ static int adis16400_probe(struct spi_device *spi)
                return -ENOMEM;
 
        st = iio_priv(indio_dev);
-       /* this is only used for removal purposes */
-       spi_set_drvdata(spi, indio_dev);
 
        /* setup the industrialio driver allocated elements */
        st->variant = &adis16400_chips[spi_get_device_id(spi)->driver_data];
index ba373d7aaa2b92d2d801950fc78f967a2b698bbe..a6f9fba3e03f4c84b5e6aff80042022dc50e4341 100644 (file)
@@ -387,8 +387,6 @@ static int adis16460_probe(struct spi_device *spi)
        if (indio_dev == NULL)
                return -ENOMEM;
 
-       spi_set_drvdata(spi, indio_dev);
-
        st = iio_priv(indio_dev);
 
        st->chip_info = &adis16460_chip_info;
index d0e84e5dee6cdd7f189864b9255abc10e08fbc9a..eb48102f94243e41c49b4f4e66864d027fa0dfc3 100644 (file)
@@ -1328,7 +1328,6 @@ static int adis16475_probe(struct spi_device *spi)
                return -ENOMEM;
 
        st = iio_priv(indio_dev);
-       spi_set_drvdata(spi, indio_dev);
 
        st->info = device_get_match_data(&spi->dev);
        if (!st->info)
index 9ec0e61b484fe0b3c6bbd725cb6c9ee3956b3f51..a869a6e52a16bec9eca5e196bd6c2ccef85d8ed7 100644 (file)
@@ -1406,8 +1406,6 @@ static int adis16480_probe(struct spi_device *spi)
        if (indio_dev == NULL)
                return -ENOMEM;
 
-       spi_set_drvdata(spi, indio_dev);
-
        st = iio_priv(indio_dev);
 
        st->chip_info = &adis16480_chip_info[id->driver_data];