hostap: use eth_hw_addr_set()
authorJakub Kicinski <kuba@kernel.org>
Mon, 18 Oct 2021 23:50:16 +0000 (16:50 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 20 Oct 2021 09:39:46 +0000 (12:39 +0300)
Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211018235021.1279697-11-kuba@kernel.org
drivers/net/wireless/intersil/hostap/hostap_hw.c

index 9a19046217df68c44493db5792040e3cd5507d2c..e459e7192ae9695f6e6ae6acbdea99f440825e60 100644 (file)
@@ -1403,14 +1403,17 @@ static int prism2_hw_init2(struct net_device *dev, int initial)
        hfa384x_events_only_cmd(dev);
 
        if (initial) {
+               u8 addr[ETH_ALEN] = {};
                struct list_head *ptr;
+
                prism2_check_sta_fw_version(local);
 
                if (hfa384x_get_rid(dev, HFA384X_RID_CNFOWNMACADDR,
-                                   dev->dev_addr, 6, 1) < 0) {
+                                   addr, ETH_ALEN, 1) < 0) {
                        printk("%s: could not get own MAC address\n",
                               dev->name);
                }
+               eth_hw_addr_set(dev, addr);
                list_for_each(ptr, &local->hostap_interfaces) {
                        iface = list_entry(ptr, struct hostap_interface, list);
                        eth_hw_addr_inherit(iface->dev, dev);