crypto: tcrypt - Fix multibuffer skcipher speed test mem leak

[ Upstream commit 1aa33fc8d4032227253ceb736f47c52b859d9683 ]

In the past, the data for mb-skcipher test has been allocated
twice, that means the first allcated memory area is without
free, which may cause a potential memory leakage. So this
patch is to remove one allocation to fix this error.

Fixes: e161c5930c15 ("crypto: tcrypt - add multibuf skcipher...")
Signed-off-by: Zhang Yiqun <zhangyiqun@phytium.com.cn>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index 3362897bf61b97bbc96606c0b335ab5230058bfa..4ada7e749390433d81b53a3f5953f5573c89b3b1 100644 (file)
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -1295,15 +1295,6 @@ static void test_mb_skcipher_speed(const char *algo, int enc, int secs,
                        goto out_free_tfm;
                }
 
-
-       for (i = 0; i < num_mb; ++i)
-               if (testmgr_alloc_buf(data[i].xbuf)) {
-                       while (i--)
-                               testmgr_free_buf(data[i].xbuf);
-                       goto out_free_tfm;
-               }
-
-
        for (i = 0; i < num_mb; ++i) {
                data[i].req = skcipher_request_alloc(tfm, GFP_KERNEL);
                if (!data[i].req) {