mailbox:armada-37xx-rwtm:remove duplicate print in armada_37xx_mbox_probe()
authorTang Bin <tangbin@cmss.chinamobile.com>
Thu, 19 Mar 2020 14:03:47 +0000 (22:03 +0800)
committerJassi Brar <jaswinder.singh@linaro.org>
Fri, 20 Mar 2020 04:00:32 +0000 (23:00 -0500)
In this function,we don't need dev_err() message because when something
goes wrong,platform_get_irq() and devm_platform_ioremap_resource() have
print an error message itself, so we should remove duplicate dev_err().

Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/armada-37xx-rwtm-mailbox.c

index 02b7b28e696947a6cc3a03e60f0f840b6d865a0d..9f2ce7f03c677971b886978c7b62d990ce614b38 100644 (file)
@@ -156,16 +156,12 @@ static int armada_37xx_mbox_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        mbox->base = devm_platform_ioremap_resource(pdev, 0);
-       if (IS_ERR(mbox->base)) {
-               dev_err(&pdev->dev, "ioremap failed\n");
+       if (IS_ERR(mbox->base))
                return PTR_ERR(mbox->base);
-       }
 
        mbox->irq = platform_get_irq(pdev, 0);
-       if (mbox->irq < 0) {
-               dev_err(&pdev->dev, "Cannot get irq\n");
+       if (mbox->irq < 0)
                return mbox->irq;
-       }
 
        mbox->dev = &pdev->dev;