RDMA/cxgb4: Use non-atomic bitmap functions when possible
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Wed, 24 Nov 2021 21:40:26 +0000 (22:40 +0100)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 25 Nov 2021 17:29:06 +0000 (13:29 -0400)
The accesses to the 'alloc->table' bitmap are protected by the
'alloc->lock' spinlock, so no concurrent accesses can happen.

So prefer the non-atomic '__[set|clear]_bit()' functions to save a few
cycles.

Link: https://lore.kernel.org/r/0c1c4505ca32f5ba4126e3e324041da191513ef2.1637789139.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/cxgb4/id_table.c

index e09faa659d68a2c47e9e829774a06df7e7544978..f64e7e02b129f1a4bced436cd4fc570d51a986c5 100644 (file)
@@ -59,7 +59,7 @@ u32 c4iw_id_alloc(struct c4iw_id_table *alloc)
                        alloc->last = obj + 1;
                if (alloc->last >= alloc->max)
                        alloc->last = 0;
-               set_bit(obj, alloc->table);
+               __set_bit(obj, alloc->table);
                obj += alloc->start;
        } else
                obj = -1;
@@ -75,7 +75,7 @@ void c4iw_id_free(struct c4iw_id_table *alloc, u32 obj)
        obj -= alloc->start;
 
        spin_lock_irqsave(&alloc->lock, flags);
-       clear_bit(obj, alloc->table);
+       __clear_bit(obj, alloc->table);
        spin_unlock_irqrestore(&alloc->lock, flags);
 }