ARM: dts: rockchip: Remove 0 point from brightness-levels on rk3288-veyron
authorAlexandru Stan <amstan@chromium.org>
Thu, 22 Oct 2020 05:04:43 +0000 (22:04 -0700)
committerHeiko Stuebner <heiko@sntech.de>
Sun, 1 Nov 2020 11:35:52 +0000 (12:35 +0100)
The extra 0 only adds one point in the userspace visible range,
so this change is almost a noop with the current driver behavior.

We don't need the 0% point, userspace seems to handle this just fine
because it uses the bl_power property to turn off the display.

Furthermore after adding "backlight: pwm_bl: Fix interpolation" patch,
the backlight interpolation will work a little differently. So we need
to preemptively remove the 0-3 segment since otherwise we would have a
252 long interpolation that would slowly go between 0 and 3, looking
really bad in userspace. So it's almost a noop/cleanup now, but it will
be required in the future.

Signed-off-by: Alexandru Stan <amstan@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20201021220404.v3.1.I96b8d872ec51171f19274e43e96cadc092881271@changeid
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm/boot/dts/rk3288-veyron-jaq.dts
arch/arm/boot/dts/rk3288-veyron-minnie.dts
arch/arm/boot/dts/rk3288-veyron-tiger.dts

index af77ab20586de11e0453feec04c31911630c0686..4a148cf1defc49650c4f3baba53e4a93dee7d2b5 100644 (file)
@@ -20,7 +20,7 @@
 
 &backlight {
        /* Jaq panel PWM must be >= 3%, so start non-zero brightness at 8 */
-       brightness-levels = <8 255>;
+       brightness-levels = <8 255>;
        num-interpolated-steps = <247>;
 };
 
index f8b69e0a16a02dbf4b0abfbf939f324263d6a5a2..82fc6fba9999277bb5c4cb519a0bc435d523ff0a 100644 (file)
@@ -39,7 +39,7 @@
 
 &backlight {
        /* Minnie panel PWM must be >= 1%, so start non-zero brightness at 3 */
-       brightness-levels = <3 255>;
+       brightness-levels = <3 255>;
        num-interpolated-steps = <252>;
 };
 
index 069f0c2c1fdfafbe4c577047369fd082629e811b..52a84cbe7a90a2068c2359a9766c511f3764eef5 100644 (file)
@@ -23,7 +23,7 @@
 
 &backlight {
        /* Tiger panel PWM must be >= 1%, so start non-zero brightness at 3 */
-       brightness-levels = <3 255>;
+       brightness-levels = <3 255>;
        num-interpolated-steps = <252>;
 };