net: hisilicon: Annotate struct rcb_common_cb with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 22 Sep 2023 17:28:48 +0000 (10:28 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 2 Oct 2023 18:24:53 +0000 (11:24 -0700)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct rcb_common_cb.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230922172858.3822653-6-keescook@chromium.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h

index a9f8059256999a0b69098b67e53aff5e5b53c6fd..c1e9b6997853ff38bb7e8053959f373f0277b16d 100644 (file)
@@ -108,7 +108,7 @@ struct rcb_common_cb {
        u32 ring_num;
        u32 desc_num; /*  desc num per queue*/
 
-       struct ring_pair_cb ring_pair_cb[];
+       struct ring_pair_cb ring_pair_cb[] __counted_by(ring_num);
 };
 
 int hns_rcb_buf_size2type(u32 buf_size);