net: wwan: iosm: fix crash in peek throughput test

Peek throughput UL test is resulting in crash. If the UL
transfer block free list is exhaust, the peeked skb is freed.
In the next transfer freed skb is referred from UL list which
results in crash.

Don't free the skb if UL transfer blocks are unavailable. The
pending skb will be picked for transfer on UL transfer block
available.

Fixes: 1f52d7b62285 ("net: wwan: iosm: Enable M.2 7360 WWAN card support")
Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
index c1636512366046f7cfbd3233330e2c1a4b7101c4..738420bd14af27f6fe79f469e1e03f98d4fe2179 100644 (file)
--- a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
+++ b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
@@ -1207,10 +1207,9 @@ static int mux_ul_dg_update_tbl_index(struct iosm_mux *ipc_mux,
                                 qlth_n_ql_size, ul_list);
        ipc_mux_ul_adb_finish(ipc_mux);
        if (ipc_mux_ul_adb_allocate(ipc_mux, adb, &ipc_mux->size_needed,
-                                   IOSM_AGGR_MUX_SIG_ADBH)) {
-               dev_kfree_skb(src_skb);
+                                   IOSM_AGGR_MUX_SIG_ADBH))
                return -ENOMEM;
-       }
+
        ipc_mux->size_needed = le32_to_cpu(adb->adbh->block_length);
 
        ipc_mux->size_needed += offsetof(struct mux_adth, dg);