dmaengine: pl330: issue_pending waits until WFP state
authorBumyong Lee <bumyong.lee@samsung.com>
Tue, 19 Dec 2023 05:50:26 +0000 (14:50 +0900)
committerVinod Koul <vkoul@kernel.org>
Fri, 22 Dec 2023 06:49:41 +0000 (12:19 +0530)
According to DMA-330 errata notice[1] 71930, DMAKILL
cannot clear internal signal, named pipeline_req_active.
it makes that pl330 would wait forever in WFP state
although dma already send dma request if pl330 gets
dma request before entering WFP state.

The errata suggests that polling until entering WFP state
as workaround and then peripherals allows to issue dma request.

[1]: https://developer.arm.com/documentation/genc008428/latest

Signed-off-by: Bumyong Lee <bumyong.lee@samsung.com>
Link: https://lore.kernel.org/r/20231219055026.118695-1-bumyong.lee@samsung.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/pl330.c

index 3cf0b38387ae5604adf7fbf07574444171c21043..c29744bfdf2c2afc4ae6a7b6fdcd963a19db2977 100644 (file)
@@ -1053,6 +1053,9 @@ static bool _trigger(struct pl330_thread *thrd)
 
        thrd->req_running = idx;
 
+       if (desc->rqtype == DMA_MEM_TO_DEV || desc->rqtype == DMA_DEV_TO_MEM)
+               UNTIL(thrd, PL330_STATE_WFP);
+
        return true;
 }