usb: renesas_usbhs: Use platform_get_irq() to get the interrupt

platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

Drop irqflags member from struct usbhs_priv as this driver is used by
two non DT users sh7757lcr and ecovec24 which do not pass
IORESOURCE_IRQ_SHAREABLE as part of their pdata. Along this drop the
IRQF_SHARED flag handling in the code.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://lore.kernel.org/r/20211220010411.12075-3-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 3af91b2b8f7690cf5094a9ff0b6d65af6432f13c..96f3939a65e203e5516cf8c31493e316fcad66d4 100644 (file)
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -589,11 +589,11 @@ static int usbhs_probe(struct platform_device *pdev)
 {
        const struct renesas_usbhs_platform_info *info;
        struct usbhs_priv *priv;
-       struct resource *irq_res;
        struct device *dev = &pdev->dev;
        struct gpio_desc *gpiod;
        int ret;
        u32 tmp;
+       int irq;
 
        /* check device node */
        if (dev_of_node(dev))
@@ -608,11 +608,9 @@ static int usbhs_probe(struct platform_device *pdev)
        }
 
        /* platform data */
-       irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-       if (!irq_res) {
-               dev_err(dev, "Not enough Renesas USB platform resources.\n");
-               return -ENODEV;
-       }
+       irq = platform_get_irq(pdev, 0);
+       if (irq < 0)
+               return irq;
 
        /* usb private data */
        priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
@@ -669,9 +667,7 @@ static int usbhs_probe(struct platform_device *pdev)
        /*
         * priv settings
         */
-       priv->irq       = irq_res->start;
-       if (irq_res->flags & IORESOURCE_IRQ_SHAREABLE)
-               priv->irqflags = IRQF_SHARED;
+       priv->irq = irq;
        priv->pdev      = pdev;
        INIT_DELAYED_WORK(&priv->notify_hotplug_work, usbhsc_notify_hotplug);
        spin_lock_init(usbhs_priv_to_lock(priv));

diff --git a/drivers/usb/renesas_usbhs/common.h b/drivers/usb/renesas_usbhs/common.h
index eb34d762a63dfa61eac916da073816d4e7efec02..3fb5bc94dc0da64f504e50a685baf9ddd6088a83 100644 (file)
--- a/drivers/usb/renesas_usbhs/common.h
+++ b/drivers/usb/renesas_usbhs/common.h
@@ -252,7 +252,6 @@ struct usbhs_priv {
 
        void __iomem *base;
        unsigned int irq;
-       unsigned long irqflags;
 
        const struct renesas_usbhs_platform_callback *pfunc;
        struct renesas_usbhs_driver_param       dparam;

diff --git a/drivers/usb/renesas_usbhs/mod.c b/drivers/usb/renesas_usbhs/mod.c
index b98112cefaa4f667ea705777164302bafb448039..f2ea3e1412d2e89acefba4295512ef287df5ba8e 100644 (file)
--- a/drivers/usb/renesas_usbhs/mod.c
+++ b/drivers/usb/renesas_usbhs/mod.c
@@ -142,7 +142,7 @@ int usbhs_mod_probe(struct usbhs_priv *priv)
 
        /* irq settings */
        ret = devm_request_irq(dev, priv->irq, usbhs_interrupt,
-                         priv->irqflags, dev_name(dev), priv);
+                              0, dev_name(dev), priv);
        if (ret) {
                dev_err(dev, "irq request err\n");
                goto mod_init_gadget_err;
@@ -219,18 +219,6 @@ static int usbhs_status_get_each_irq(struct usbhs_priv *priv,
        usbhs_unlock(priv, flags);
        /********************  spin unlock ******************/
 
-       /*
-        * Check whether the irq enable registers and the irq status are set
-        * when IRQF_SHARED is set.
-        */
-       if (priv->irqflags & IRQF_SHARED) {
-               if (!(intenb0 & state->intsts0) &&
-                   !(intenb1 & state->intsts1) &&
-                   !(state->bempsts) &&
-                   !(state->brdysts))
-                       return -EIO;
-       }
-
        return 0;
 }