remoteproc/mediatek: unprepare clk if scp_before_load fails

Fixes the error handling to unprepare clk if scp_before_load fails.

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Fixes: fd0b6c1ff85a ("remoteproc/mediatek: Add support for mt8192 SCP")
Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
Link: https://lore.kernel.org/r/20201203155914.3844426-1-tzungbi@google.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index 5f42b9ce718524b21178e25a44319f75b933a8a4..5e5705fe35a8f06f6898c5df5152973c075cd566 100644 (file)
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -350,9 +350,10 @@ static int scp_load(struct rproc *rproc, const struct firmware *fw)
 
        ret = scp->data->scp_before_load(scp);
        if (ret < 0)
-               return ret;
+               goto leave;
 
        ret = scp_elf_load_segments(rproc, fw);
+leave:
        clk_disable_unprepare(scp->clk);
 
        return ret;