media: i2c: st-mipid02: Use the correct div function
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 29 Apr 2024 15:05:00 +0000 (16:05 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 3 May 2024 10:15:47 +0000 (11:15 +0100)
link_freq does not fit in 32 bits.

Found by cocci:
drivers/media/i2c/st-mipid02.c:329:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_s64 instead.

Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-21-3c4865f5a4b0@chromium.org
Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/st-mipid02.c

index f250640729ca49af4e2cbe2683aa90fa3110923a..b947a55281f0e4536db9717ecece7f08f9e3b4f9 100644 (file)
@@ -326,7 +326,7 @@ static int mipid02_configure_from_rx_speed(struct mipid02_dev *bridge,
        }
 
        dev_dbg(&client->dev, "detect link_freq = %lld Hz", link_freq);
-       do_div(ui_4, link_freq);
+       ui_4 = div64_u64(ui_4, link_freq);
        bridge->r.clk_lane_reg1 |= ui_4 << 2;
 
        return 0;