PCI: brcmstb: Assert fundamental reset on initialization
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Thu, 7 May 2020 17:20:20 +0000 (19:20 +0200)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Mon, 11 May 2020 10:42:10 +0000 (11:42 +0100)
While preparing the driver for upstream this detail was missed.

If not asserted during the initialization process, devices connected on
the bus will not be made aware of the internal reset happening. This,
potentially resulting in unexpected behavior.

Link: https://lore.kernel.org/r/20200507172020.18000-1-nsaenzjulienne@suse.de
Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controller driver")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
drivers/pci/controller/pcie-brcmstb.c

index 6d79d14527a6632333609858d4843a27d98ff290..9aa4cdc7557e9bba16745b8a8be2e5c1b29957fd 100644 (file)
@@ -697,6 +697,7 @@ static int brcm_pcie_setup(struct brcm_pcie *pcie)
 
        /* Reset the bridge */
        brcm_pcie_bridge_sw_init_set(pcie, 1);
+       brcm_pcie_perst_set(pcie, 1);
 
        usleep_range(100, 200);