ath9k: use swap() to make code cleaner
authorYang Guang <cgel.zte@gmail.com>
Thu, 28 Oct 2021 01:04:51 +0000 (01:04 +0000)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 1 Nov 2021 14:20:03 +0000 (16:20 +0200)
Using swap() make it more readable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211028010451.7754-1-yang.guang5@zte.com.cn
drivers/net/wireless/ath/ath9k/ar9003_calib.c

index 7e27a06e5df197cbf5e5a41b97e61723d38d72a8..dc24da1ff00b1ac0ab5732bd8e9c3ffbb53d9803 100644 (file)
@@ -1005,24 +1005,20 @@ static void __ar955x_tx_iq_cal_sort(struct ath_hw *ah,
                                    int i, int nmeasurement)
 {
        struct ath_common *common = ath9k_hw_common(ah);
-       int im, ix, iy, temp;
+       int im, ix, iy;
 
        for (im = 0; im < nmeasurement; im++) {
                for (ix = 0; ix < MAXIQCAL - 1; ix++) {
                        for (iy = ix + 1; iy <= MAXIQCAL - 1; iy++) {
                                if (coeff->mag_coeff[i][im][iy] <
                                    coeff->mag_coeff[i][im][ix]) {
-                                       temp = coeff->mag_coeff[i][im][ix];
-                                       coeff->mag_coeff[i][im][ix] =
-                                               coeff->mag_coeff[i][im][iy];
-                                       coeff->mag_coeff[i][im][iy] = temp;
+                                       swap(coeff->mag_coeff[i][im][ix],
+                                            coeff->mag_coeff[i][im][iy]);
                                }
                                if (coeff->phs_coeff[i][im][iy] <
                                    coeff->phs_coeff[i][im][ix]) {
-                                       temp = coeff->phs_coeff[i][im][ix];
-                                       coeff->phs_coeff[i][im][ix] =
-                                               coeff->phs_coeff[i][im][iy];
-                                       coeff->phs_coeff[i][im][iy] = temp;
+                                       swap(coeff->phs_coeff[i][im][ix],
+                                            coeff->phs_coeff[i][im][iy]);
                                }
                        }
                }