selftests: drv-net: add stdout to the command failed exception
authorJakub Kicinski <kuba@kernel.org>
Tue, 16 Apr 2024 00:45:51 +0000 (17:45 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 17 Apr 2024 01:54:06 +0000 (18:54 -0700)
ping prints all the info to stdout. To make debug easier capture
stdout in the Exception raised when command unexpectedly fails.

Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20240416004556.1618804-2-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/lib/py/utils.py

index f0d425731fd419c32a07fe35c258d409d10bb2de..19612348c30d022df59b01ae85fa4e3dd5a2e781 100644 (file)
@@ -33,7 +33,8 @@ class cmd:
         if self.proc.returncode != 0 and fail:
             if len(stderr) > 0 and stderr[-1] == "\n":
                 stderr = stderr[:-1]
-            raise Exception("Command failed: %s\n%s" % (self.proc.args, stderr))
+            raise Exception("Command failed: %s\nSTDOUT: %s\nSTDERR: %s" %
+                            (self.proc.args, stdout, stderr))
 
 
 def ip(args, json=None, ns=None):