nvme-tcp: only evaluate 'tls' option if TLS is selected
authorHannes Reinecke <hare@suse.de>
Tue, 14 Nov 2023 13:18:21 +0000 (14:18 +0100)
committerKeith Busch <kbusch@kernel.org>
Mon, 20 Nov 2023 17:25:32 +0000 (09:25 -0800)
We only need to evaluate the 'tls' connect option if TLS is
enabled; otherwise we might be getting a link error.

Fixes: 706add13676d ("nvme: keyring: fix conditional compilation")
Reported-by: kernel test robot <yujie.liu@intel.com>
Closes: https://lore.kernel.org/r/202311140426.0eHrTXBr-lkp@intel.com/
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/tcp.c

index 89661a9cf850d493d0ff6e69b60a5525154cfbc4..6ed79481551743b1b4cfdb604d640af34ad10f62 100644 (file)
@@ -1916,7 +1916,7 @@ static int nvme_tcp_alloc_admin_queue(struct nvme_ctrl *ctrl)
        int ret;
        key_serial_t pskid = 0;
 
-       if (ctrl->opts->tls) {
+       if (IS_ENABLED(CONFIG_NVME_TCP_TLS) && ctrl->opts->tls) {
                if (ctrl->opts->tls_key)
                        pskid = key_serial(ctrl->opts->tls_key);
                else