projects
/
qemu.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0795b98
)
hw/cxl: drop pointless memory_region_transaction_guards
author
Jonathan Cameron
<Jonathan.Cameron@huawei.com>
Fri, 21 Apr 2023 13:59:04 +0000
(14:59 +0100)
committer
Michael S. Tsirkin
<mst@redhat.com>
Fri, 19 May 2023 05:36:09 +0000
(
01:36
-0400)
Not clear what intent was here, but probably based on a misunderstanding
of what these guards are for.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <
20230421135906
.3515-2-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/cxl/cxl-component-utils.c
patch
|
blob
|
history
diff --git
a/hw/cxl/cxl-component-utils.c
b/hw/cxl/cxl-component-utils.c
index b665d4f56576f27dac6d79ece54d8aa7f84d96a1..324be79b116674a34e18031cad0d82fc699a56e5 100644
(file)
--- a/
hw/cxl/cxl-component-utils.c
+++ b/
hw/cxl/cxl-component-utils.c
@@
-47,14
+47,12
@@
static void dumb_hdm_handler(CXLComponentState *cxl_cstate, hwaddr offset,
break;
}
- memory_region_transaction_begin();
stl_le_p((uint8_t *)cache_mem + offset, value);
if (should_commit) {
ARRAY_FIELD_DP32(cache_mem, CXL_HDM_DECODER0_CTRL, COMMIT, 0);
ARRAY_FIELD_DP32(cache_mem, CXL_HDM_DECODER0_CTRL, ERR, 0);
ARRAY_FIELD_DP32(cache_mem, CXL_HDM_DECODER0_CTRL, COMMITTED, 1);
}
- memory_region_transaction_commit();
}
static void cxl_cache_mem_write_reg(void *opaque, hwaddr offset, uint64_t value,