um: Replace if (cond) BUG() with BUG_ON()
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 17 Mar 2021 07:11:36 +0000 (15:11 +0800)
committerRichard Weinberger <richard@nod.at>
Thu, 15 Apr 2021 21:10:37 +0000 (23:10 +0200)
Fix the following coccinelle reports:
./arch/um/kernel/mem.c:77:3-6: WARNING: Use BUG_ON instead of if
condition followed by BUG.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/um/kernel/mem.c

index 9242dc91d75193475cb105b4e6e6ab016f1a7a08..22e28bfb22cc87bc30c0a738ee937c0827c0f046 100644 (file)
@@ -73,8 +73,7 @@ static void __init one_page_table_init(pmd_t *pmd)
 
                set_pmd(pmd, __pmd(_KERNPG_TABLE +
                                           (unsigned long) __pa(pte)));
-               if (pte != pte_offset_kernel(pmd, 0))
-                       BUG();
+               BUG_ON(pte != pte_offset_kernel(pmd, 0));
        }
 }