OPP: call of_node_put() on error path in _bandwidth_supported()

[ Upstream commit 907ed123b9d096c73e9361f6cd4097f0691497f2 ]

This code does not call of_node_put(opp_np) if of_get_next_available_child()
returns NULL.  But it should.

Fixes: 45679f9b508f ("opp: Don't parse icc paths unnecessarily")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index c32ae7497392b4527e9ddbfa315963286d3a671b..3028353afece37e28332b2c35572642875272b3e 100644 (file)
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -437,11 +437,11 @@ static int _bandwidth_supported(struct device *dev, struct opp_table *opp_table)
 
        /* Checking only first OPP is sufficient */
        np = of_get_next_available_child(opp_np, NULL);
+       of_node_put(opp_np);
        if (!np) {
                dev_err(dev, "OPP table empty\n");
                return -EINVAL;
        }
-       of_node_put(opp_np);
 
        prop = of_find_property(np, "opp-peak-kBps", NULL);
        of_node_put(np);