dmaengine: at_hdmac: Switch atomic allocations to GFP_NOWAIT
authorTudor Ambarus <tudor.ambarus@microchip.com>
Thu, 23 Jan 2020 14:03:09 +0000 (14:03 +0000)
committerVinod Koul <vkoul@kernel.org>
Tue, 25 Feb 2020 05:57:27 +0000 (11:27 +0530)
Avoids sleeping without depleting the emergency pool.
The rationale being that in most cases a dma device is either
offloading an operation that will automatically fallback to
software when the descriptor allocation fails, or we can simply poll
and wait for the dma device to release some in use descriptors.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Link: https://lore.kernel.org/r/20200123140237.125799-5-tudor.ambarus@microchip.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/at_hdmac.c

index 44d998bc894b3222d0c0063aead0978a32d582b6..8e8e04bd1b28a84a2a0073f10f9fdb2c844f975f 100644 (file)
@@ -147,7 +147,7 @@ static struct at_desc *atc_desc_get(struct at_dma_chan *atchan)
 
        /* no more descriptor available in initial pool: create one more */
        if (!ret)
-               ret = atc_alloc_descriptor(&atchan->chan_common, GFP_ATOMIC);
+               ret = atc_alloc_descriptor(&atchan->chan_common, GFP_NOWAIT);
 
        return ret;
 }
@@ -931,7 +931,7 @@ atc_prep_dma_memset(struct dma_chan *chan, dma_addr_t dest, int value,
                return NULL;
        }
 
-       vaddr = dma_pool_alloc(atdma->memset_pool, GFP_ATOMIC, &paddr);
+       vaddr = dma_pool_alloc(atdma->memset_pool, GFP_NOWAIT, &paddr);
        if (!vaddr) {
                dev_err(chan2dev(chan), "%s: couldn't allocate buffer\n",
                        __func__);
@@ -989,7 +989,7 @@ atc_prep_dma_memset_sg(struct dma_chan *chan,
                return NULL;
        }
 
-       vaddr = dma_pool_alloc(atdma->memset_pool, GFP_ATOMIC, &paddr);
+       vaddr = dma_pool_alloc(atdma->memset_pool, GFP_NOWAIT, &paddr);
        if (!vaddr) {
                dev_err(chan2dev(chan), "%s: couldn't allocate buffer\n",
                        __func__);