quota: Remove BUG_ON from dqget()

dqget() checks whether dquot->dq_sb is set when returning it using
BUG_ON. Firstly this doesn't work as an invalidation check for quite
some time (we release dquot with dq_sb set these days), secondly using
BUG_ON is quite harsh. Use WARN_ON_ONCE and check whether dquot is still
hashed instead.

Signed-off-by: Jan Kara <jack@suse.cz>

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index 85edbbafaaa42b99fb001a38a5697f43d07643a7..5f5481c43d9843def2155cbefff973021bd812d3 100644 (file)
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -984,9 +984,8 @@ we_slept:
         * smp_mb__before_atomic() in dquot_acquire().
         */
        smp_rmb();
-#ifdef CONFIG_QUOTA_DEBUG
-       BUG_ON(!dquot->dq_sb);  /* Has somebody invalidated entry under us? */
-#endif
+       /* Has somebody invalidated entry under us? */
+       WARN_ON_ONCE(hlist_unhashed(&dquot->dq_hash));
 out:
        if (empty)
                do_destroy_dquot(empty);