selftests/bpf: improve netcnt test robustness
authorAndrii Nakryiko <andrii@kernel.org>
Mon, 15 May 2023 20:48:33 +0000 (13:48 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 17 May 2023 03:57:16 +0000 (20:57 -0700)
Change netcnt to demand at least 10K packets, as we frequently see some
stray packet arriving during the test in BPF CI. It seems more important
to make sure we haven't lost any packet than enforcing exact number of
packets.

Cc: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/r/20230515204833.2832000-1-andrii@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/prog_tests/netcnt.c

index d3915c58d0e17f45c593c4f16c020430577cc22d..c3333edd029f82296f1a7e39bb3caf852b97be68 100644 (file)
@@ -67,12 +67,12 @@ void serial_test_netcnt(void)
        }
 
        /* No packets should be lost */
-       ASSERT_EQ(packets, 10000, "packets");
+       ASSERT_GE(packets, 10000, "packets");
 
        /* Let's check that bytes counter matches the number of packets
         * multiplied by the size of ipv6 ICMP packet.
         */
-       ASSERT_EQ(bytes, packets * 104, "bytes");
+       ASSERT_GE(bytes, packets * 104, "bytes");
 
 err:
        if (cg_fd != -1)