misc: ti-st: Replace GFP_ATOMIC with GFP_KERNEL in kim_probe
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 11 Apr 2018 03:07:32 +0000 (11:07 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Apr 2018 11:31:27 +0000 (13:31 +0200)
kim_probe() is never called in atomic context.
This function is only set as ".probe" in struct platform_driver.

Despite never getting called from atomic context,
kim_probe() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/ti-st/st_kim.c

index b77aacafc3fcd96bd52af1bb55a60123b22bdcf6..5ec3f5a43718741021ccab9af44daecf61b7c3ce 100644 (file)
@@ -735,7 +735,7 @@ static int kim_probe(struct platform_device *pdev)
                st_kim_devices[0] = pdev;
        }
 
-       kim_gdata = kzalloc(sizeof(struct kim_data_s), GFP_ATOMIC);
+       kim_gdata = kzalloc(sizeof(struct kim_data_s), GFP_KERNEL);
        if (!kim_gdata) {
                pr_err("no mem to allocate");
                return -ENOMEM;