video: fbdev: pxa168fb: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
index 47e6a1d0d2293ef1f5a4d7ec0a064153bfcbe9f0..35cf806a92199e907ab602e1b55c270edb5c5151 100644 (file)
--- a/drivers/video/fbdev/pxa168fb.c
+++ b/drivers/video/fbdev/pxa168fb.c
@@ -606,10 +606,9 @@ static int pxa168fb_probe(struct platform_device *pdev)
        }
 
        clk = devm_clk_get(&pdev->dev, "LCDCLK");
-       if (IS_ERR(clk)) {
-               dev_err(&pdev->dev, "unable to get LCDCLK");
-               return PTR_ERR(clk);
-       }
+       if (IS_ERR(clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(clk),
+                                    "unable to get LCDCLK");
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        if (res == NULL) {