migration: Don't try to set *errp directly
authorEduardo Habkost <ehabkost@redhat.com>
Thu, 8 Jun 2017 13:39:05 +0000 (10:39 -0300)
committerJuan Quintela <quintela@redhat.com>
Tue, 13 Jun 2017 09:00:44 +0000 (11:00 +0200)
Assigning directly to *errp is not valid, as errp may be NULL,
&error_fatal, or &error_abort.  Use error_propagate() instead.

Cc: Juan Quintela <quintela@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
migration/migration.c

index 9dfa19abe1d5749e13574c1e54f56a4859f329a4..ae087df56b5344d76e06c85e5c1d1eb13ed38fb3 100644 (file)
@@ -1179,7 +1179,7 @@ bool migration_is_blocked(Error **errp)
     }
 
     if (migration_blockers) {
-        *errp = error_copy(migration_blockers->data);
+        error_propagate(errp, error_copy(migration_blockers->data));
         return true;
     }