scsi: mvsas: Use DEVICE_ATTR_RO()/RW() macro

Use DEVICE_ATTR_RO()/RW() macro helper instead of plain DEVICE_ATTR(),
which makes the code a bit shorter and easier to read.

Link: https://lore.kernel.org/r/20210616034419.725-5-thunder.leizhen@huawei.com
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
index b03c0f35d7b047208e2315d4a4c532ac6302b027..f18dd97035955349555ec9a8aace3931ea9c057b 100644 (file)
--- a/drivers/scsi/mvsas/mv_init.c
+++ b/drivers/scsi/mvsas/mv_init.c
@@ -693,22 +693,17 @@ static struct pci_driver mvs_pci_driver = {
        .remove         = mvs_pci_remove,
 };
 
-static ssize_t
-mvs_show_driver_version(struct device *cdev,
-               struct device_attribute *attr,  char *buffer)
+static ssize_t driver_version_show(struct device *cdev,
+                                  struct device_attribute *attr, char *buffer)
 {
        return snprintf(buffer, PAGE_SIZE, "%s\n", DRV_VERSION);
 }
 
-static DEVICE_ATTR(driver_version,
-                        S_IRUGO,
-                        mvs_show_driver_version,
-                        NULL);
+static DEVICE_ATTR_RO(driver_version);
 
-static ssize_t
-mvs_store_interrupt_coalescing(struct device *cdev,
-                       struct device_attribute *attr,
-                       const char *buffer, size_t size)
+static ssize_t interrupt_coalescing_store(struct device *cdev,
+                                         struct device_attribute *attr,
+                                         const char *buffer, size_t size)
 {
        unsigned int val = 0;
        struct mvs_info *mvi = NULL;
@@ -746,16 +741,13 @@ mvs_store_interrupt_coalescing(struct device *cdev,
        return strlen(buffer);
 }
 
-static ssize_t mvs_show_interrupt_coalescing(struct device *cdev,
-                       struct device_attribute *attr, char *buffer)
+static ssize_t interrupt_coalescing_show(struct device *cdev,
+                                        struct device_attribute *attr, char *buffer)
 {
        return snprintf(buffer, PAGE_SIZE, "%d\n", interrupt_coalescing);
 }
 
-static DEVICE_ATTR(interrupt_coalescing,
-                        S_IRUGO|S_IWUSR,
-                        mvs_show_interrupt_coalescing,
-                        mvs_store_interrupt_coalescing);
+static DEVICE_ATTR_RW(interrupt_coalescing);
 
 static int __init mvs_init(void)
 {