target/hexagon/opcodes: Add missing varargs cleanup
authorPhilippe Mathieu-Daudé <f4bug@amsat.org>
Tue, 23 Feb 2021 11:12:53 +0000 (12:12 +0100)
committerRichard Henderson <richard.henderson@linaro.org>
Sun, 7 Mar 2021 01:35:43 +0000 (17:35 -0800)
Fix a trivial incorrect usage of variable argument macros detected
by Coverity (missing_va_end: va_end was not called for ap).

Fixes: Coverity CID 1446720 (VARARGS)
Fixes: e3c00c2ed75 ("Hexagon (target/hexagon) opcode data structures")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id: <20210223111253.2831285-1-f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
target/hexagon/opcodes.c

index 4eef5fc40f6dc289d596a8a531452fb6681cfcba..35d790cdd5b2a775cb2decf061d7e259a84ad79f 100644 (file)
@@ -82,6 +82,7 @@ static void init_attribs(int tag, ...)
     while ((attr = va_arg(ap, int)) != 0) {
         set_bit(attr, opcode_attribs[tag]);
     }
+    va_end(ap);
 }
 
 const OpcodeEncoding opcode_encodings[] = {