scripts/checkpatch.pl: emit error when using assert(false)

This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-ID: <20240919044641.386068-35-pierrick.bouvier@linaro.org>
[thuth: Split long line to avoid checkpatch error]
Signed-off-by: Thomas Huth <thuth@redhat.com>

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 65b6f46f905dae44a555804eb91ce9c95c83e7a0..1b21249c91e7e32c06aa5f28250d7803eda8e2ed 100755 (executable)
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3102,6 +3102,10 @@ sub process {
                if ($line =~ /\b(g_)?assert\(0\)/) {
                        ERROR("use g_assert_not_reached() instead of assert(0)\n" . $herecurr);
                }
+               if ($line =~ /\b(g_)?assert\(false\)/) {
+                       ERROR("use g_assert_not_reached() instead of assert(false)\n" .
+                             $herecurr);
+               }
                if ($line =~ /\bstrerrorname_np\(/) {
                        ERROR("use strerror() instead of strerrorname_np()\n" . $herecurr);
                }