media: rockchip: rga: fix clock cleanup

Fix this smatch warning:

drivers/media/platform/rockchip/rga/rga.c:734 rga_enable_clocks() warn: 'rga->sclk' from clk_prepare_enable() not released on lines: 734.

The reason is that aclk should be disabled/unprepared before
sclk, instead of the other way around.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Jacob Chen <jacob-chen@iotwrt.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
index e4b8ce9ab3c694b0f2709033bd8506175d33a7cd..f1c532a5802ac29673904522eeeb92fa1341bb7a 100644 (file)
--- a/drivers/media/platform/rockchip/rga/rga.c
+++ b/drivers/media/platform/rockchip/rga/rga.c
@@ -723,10 +723,10 @@ static int rga_enable_clocks(struct rockchip_rga *rga)
 
        return 0;
 
-err_disable_sclk:
-       clk_disable_unprepare(rga->sclk);
 err_disable_aclk:
        clk_disable_unprepare(rga->aclk);
+err_disable_sclk:
+       clk_disable_unprepare(rga->sclk);
 
        return ret;
 }