resource/image: Fix "always false" condition
authorIskander (Alex) Sharipov <quasilyte@gmail.com>
Mon, 10 Dec 2018 14:31:44 +0000 (17:31 +0300)
committerBjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
Mon, 10 Dec 2018 14:31:44 +0000 (15:31 +0100)
Found using gocritic linter.

resource/image.go

index 0fdabf788f6de83f76564312b040e7feddebefd3..6dea4cbb83ea682858621fa9f2d64a9e56c4b5fd 100644 (file)
@@ -376,7 +376,7 @@ func parseImageConfig(config string) (imageConfig, error) {
                        if err != nil {
                                return c, err
                        }
-                       if c.Quality < 1 && c.Quality > 100 {
+                       if c.Quality < 1 || c.Quality > 100 {
                                return c, errors.New("quality ranges from 1 to 100 inclusive")
                        }
                } else if part[0] == 'r' {