ASoC: SOF: Intel: tgl: Add fw_regs area to debugfs map for IPC4

Expose the firmware registers via debugfs. it can be of great help while
debugging complex issues.
The area is only available with IPC4.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://msgid.link/r/20240409113349.21623-2-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/sof/intel/tgl.c b/sound/soc/sof/intel/tgl.c
index c2bb04c89b9d6b371d04f8b34c66a84472c72552..6cda47a78118a5a27197c5b40ec2ee55783ca11c 100644 (file)
--- a/sound/soc/sof/intel/tgl.c
+++ b/sound/soc/sof/intel/tgl.c
@@ -22,6 +22,13 @@ static const struct snd_sof_debugfs_map tgl_dsp_debugfs[] = {
        {"dsp", HDA_DSP_BAR,  0, 0x10000, SOF_DEBUGFS_ACCESS_ALWAYS},
 };
 
+static const struct snd_sof_debugfs_map tgl_ipc4_dsp_debugfs[] = {
+       {"hda", HDA_DSP_HDA_BAR, 0, 0x4000, SOF_DEBUGFS_ACCESS_ALWAYS},
+       {"pp", HDA_DSP_PP_BAR,  0, 0x1000, SOF_DEBUGFS_ACCESS_ALWAYS},
+       {"dsp", HDA_DSP_BAR,  0, 0x10000, SOF_DEBUGFS_ACCESS_ALWAYS},
+       {"fw_regs", HDA_DSP_BAR,  SRAM_WINDOW_OFFSET(0), 0x1000, SOF_DEBUGFS_ACCESS_D0_ONLY},
+};
+
 static int tgl_dsp_core_get(struct snd_sof_dev *sdev, int core)
 {
        const struct sof_ipc_pm_ops *pm_ops = sdev->ipc->ops->pm;
@@ -75,6 +82,8 @@ int sof_tgl_ops_init(struct snd_sof_dev *sdev)
 
                /* debug */
                sof_tgl_ops.ipc_dump    = cnl_ipc_dump;
+               sof_tgl_ops.debug_map   = tgl_dsp_debugfs;
+               sof_tgl_ops.debug_map_count = ARRAY_SIZE(tgl_dsp_debugfs);
 
                sof_tgl_ops.set_power_state = hda_dsp_set_power_state_ipc3;
        }
@@ -105,6 +114,8 @@ int sof_tgl_ops_init(struct snd_sof_dev *sdev)
                /* debug */
                sof_tgl_ops.ipc_dump    = cnl_ipc4_dump;
                sof_tgl_ops.dbg_dump    = hda_ipc4_dsp_dump;
+               sof_tgl_ops.debug_map   = tgl_ipc4_dsp_debugfs;
+               sof_tgl_ops.debug_map_count = ARRAY_SIZE(tgl_ipc4_dsp_debugfs);
 
                sof_tgl_ops.set_power_state = hda_dsp_set_power_state_ipc4;
        }
@@ -112,10 +123,6 @@ int sof_tgl_ops_init(struct snd_sof_dev *sdev)
        /* set DAI driver ops */
        hda_set_dai_drv_ops(sdev, &sof_tgl_ops);
 
-       /* debug */
-       sof_tgl_ops.debug_map   = tgl_dsp_debugfs;
-       sof_tgl_ops.debug_map_count     = ARRAY_SIZE(tgl_dsp_debugfs);
-
        /* pre/post fw run */
        sof_tgl_ops.post_fw_run = hda_dsp_post_fw_run;