bcachefs: Delete weird hacky transaction restart injection
authorKent Overstreet <kent.overstreet@linux.dev>
Sun, 11 Jun 2023 22:24:04 +0000 (18:24 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:10:04 +0000 (17:10 -0400)
since we currently don't have a good fault injection library,
bch2_btree_insert_node() was randomly injecting faults based on
local_clock().

At the very least this should have been a debug mode only thing, but
this is a brittle method so let's just delete it.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/btree_update_interior.c

index 66da1da2f0757eaa14b2417d7b305813bb32b77a..d2811c4756b7d7be5f753d26ad08c2c16778a856 100644 (file)
@@ -1674,9 +1674,6 @@ static int bch2_btree_insert_node(struct btree_update *as, struct btree_trans *t
        BUG_ON(!as || as->b);
        bch2_verify_keylist_sorted(keys);
 
-       if ((local_clock() & 63) == 63)
-               return btree_trans_restart(trans, BCH_ERR_transaction_restart_split_race);
-
        ret = bch2_btree_node_lock_write(trans, path, &b->c);
        if (ret)
                return ret;