mm: Remove unused vm_brk()
authorKees Cook <keescook@chromium.org>
Fri, 29 Sep 2023 03:24:34 +0000 (20:24 -0700)
committerKees Cook <keescook@chromium.org>
Wed, 4 Oct 2023 02:48:44 +0000 (19:48 -0700)
With fs/binfmt_elf.c fully refactored to use the new elf_load() helper,
there are no more users of vm_brk(), so remove it.

Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Suggested-by: Eric Biederman <ebiederm@xmission.com>
Tested-by: Pedro Falcato <pedro.falcato@gmail.com>
Signed-off-by: Sebastian Ott <sebott@redhat.com>
Link: https://lore.kernel.org/r/20230929032435.2391507-6-keescook@chromium.org
Signed-off-by: Kees Cook <keescook@chromium.org>
include/linux/mm.h
mm/mmap.c
mm/nommu.c

index bf5d0b1b16f4341e8851d9bdfef30df631f62226..216dd0c6dcf8519d7c9f6601e66f3c5090869c5d 100644 (file)
@@ -3308,8 +3308,7 @@ static inline void mm_populate(unsigned long addr, unsigned long len)
 static inline void mm_populate(unsigned long addr, unsigned long len) {}
 #endif
 
-/* These take the mm semaphore themselves */
-extern int __must_check vm_brk(unsigned long, unsigned long);
+/* This takes the mm semaphore itself */
 extern int __must_check vm_brk_flags(unsigned long, unsigned long, unsigned long);
 extern int vm_munmap(unsigned long, size_t);
 extern unsigned long __must_check vm_mmap(struct file *, unsigned long,
index b56a7f0c9f856509a7a17eac92c71f2ce30b659c..34d2337ace59e9bc7195c13106150c7b3eaead2c 100644 (file)
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -3174,12 +3174,6 @@ limits_failed:
 }
 EXPORT_SYMBOL(vm_brk_flags);
 
-int vm_brk(unsigned long addr, unsigned long len)
-{
-       return vm_brk_flags(addr, len, 0);
-}
-EXPORT_SYMBOL(vm_brk);
-
 /* Release all mmaps. */
 void exit_mmap(struct mm_struct *mm)
 {
index 7f9e9e5a0e12ee5217191937a3725ac89ce28047..23c43c208f2b3257fc260f4e9afa6c4780dc2295 100644 (file)
@@ -1531,11 +1531,6 @@ void exit_mmap(struct mm_struct *mm)
        mmap_write_unlock(mm);
 }
 
-int vm_brk(unsigned long addr, unsigned long len)
-{
-       return -ENOMEM;
-}
-
 /*
  * expand (or shrink) an existing mapping, potentially moving it at the same
  * time (controlled by the MREMAP_MAYMOVE flag and available VM space)