net/mlx5e: Use IS_ERR() to check and simplify code
authorTang Bin <tangbin@cmss.chinamobile.com>
Fri, 15 May 2020 23:06:33 +0000 (07:06 +0800)
committerSaeed Mahameed <saeedm@mellanox.com>
Fri, 22 May 2020 23:46:07 +0000 (16:46 -0700)
Use IS_ERR() and PTR_ERR() instead of PTR_ERR_OR_ZERO() to
simplify code, avoid redundant judgements.

Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c

index b45c3f46570bdc5b38f4d177afadd17c1b1c92d2..9f50a1d3c5ccd2e749156eb0dc763e698112213e 100644 (file)
@@ -96,9 +96,8 @@ static int mlx5e_route_lookup_ipv4(struct mlx5e_priv *priv,
        }
 
        rt = ip_route_output_key(dev_net(mirred_dev), fl4);
-       ret = PTR_ERR_OR_ZERO(rt);
-       if (ret)
-               return ret;
+       if (IS_ERR(rt))
+               return PTR_ERR(rt);
 
        if (mlx5_lag_is_multipath(mdev) && rt->rt_gw_family != AF_INET) {
                ip_rt_put(rt);