iio: adc: fsl-imx25-gcq: use 'time_left' variable with wait_for_completion_interrupti...
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 29 Apr 2024 11:33:06 +0000 (13:33 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 29 Apr 2024 20:06:18 +0000 (21:06 +0100)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_interruptible_timeout() causing patterns like:

timeout = wait_for_completion_interruptible_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240429113313.68359-4-wsa+renesas@sang-engineering.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/fsl-imx25-gcq.c

index 394396b916309e2cbb38f6fcc7f2e71614b189ef..b680690631dbb777f465c7bf77a62db208d52f4e 100644 (file)
@@ -108,7 +108,7 @@ static int mx25_gcq_get_raw_value(struct device *dev,
                                  struct mx25_gcq_priv *priv,
                                  int *val)
 {
-       long timeout;
+       long time_left;
        u32 data;
 
        /* Setup the configuration we want to use */
@@ -121,12 +121,12 @@ static int mx25_gcq_get_raw_value(struct device *dev,
        regmap_update_bits(priv->regs, MX25_ADCQ_CR, MX25_ADCQ_CR_FQS,
                           MX25_ADCQ_CR_FQS);
 
-       timeout = wait_for_completion_interruptible_timeout(
+       time_left = wait_for_completion_interruptible_timeout(
                &priv->completed, MX25_GCQ_TIMEOUT);
-       if (timeout < 0) {
+       if (time_left < 0) {
                dev_err(dev, "ADC wait for measurement failed\n");
-               return timeout;
-       } else if (timeout == 0) {
+               return time_left;
+       } else if (time_left == 0) {
                dev_err(dev, "ADC timed out\n");
                return -ETIMEDOUT;
        }