Input: stmfts - fix reference leak in stmfts_input_open

pm_runtime_get_sync() will increment pm usage counter even it
failed. Forgetting to call pm_runtime_put_noidle will result
in reference leak in stmfts_input_open, so we should fix it.

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Link: https://lore.kernel.org/r/20220317131604.53538-1-zhengyongjun3@huawei.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
index bc11203c9cf785f5afcdf070ed5314185573a1cd..72e0b767e1ba4c87c31b5346c45746f82ff9773b 100644 (file)
--- a/drivers/input/touchscreen/stmfts.c
+++ b/drivers/input/touchscreen/stmfts.c
@@ -339,11 +339,11 @@ static int stmfts_input_open(struct input_dev *dev)
 
        err = pm_runtime_get_sync(&sdata->client->dev);
        if (err < 0)
-               return err;
+               goto out;
 
        err = i2c_smbus_write_byte(sdata->client, STMFTS_MS_MT_SENSE_ON);
        if (err)
-               return err;
+               goto out;
 
        mutex_lock(&sdata->mutex);
        sdata->running = true;
@@ -366,7 +366,9 @@ static int stmfts_input_open(struct input_dev *dev)
                                 "failed to enable touchkey\n");
        }
 
-       return 0;
+out:
+       pm_runtime_put_noidle(&sdata->client->dev);
+       return err;
 }
 
 static void stmfts_input_close(struct input_dev *dev)