scsi: target: drop xcopy DISK BLOCK LENGTH debug
authorDavid Disseldorp <ddiss@suse.de>
Fri, 27 Mar 2020 14:19:51 +0000 (15:19 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 29 Mar 2020 22:10:59 +0000 (18:10 -0400)
The DISK BLOCK LENGTH field is carried with XCOPY target descriptors on the
wire, but is currently unmarshalled during 0x02 segment descriptor
passing. The unmarshalled value is currently unused, so drop it.

Link: https://lore.kernel.org/r/20200327141954.955-3-ddiss@suse.de
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_xcopy.c
drivers/target/target_core_xcopy.h

index 7e5b13da0c20b313de50f526326de63d4deac90b..66b68295c50f026eaeadc51c93dbd46dece87619 100644 (file)
@@ -315,11 +315,6 @@ static int target_xcopy_parse_segdesc_02(struct se_cmd *se_cmd, struct xcopy_op
                xop->nolb, (unsigned long long)xop->src_lba,
                (unsigned long long)xop->dst_lba);
 
-       if (dc != 0) {
-               xop->dbl = get_unaligned_be24(&desc[29]);
-
-               pr_debug("XCOPY seg desc 0x02: DC=1 w/ dbl: %u\n", xop->dbl);
-       }
        return 0;
 }
 
index 26ba4c3c9cffda838e9dac362ffebbbb019dce90..0840b03e8faae25df3278ad0ac077ec4ffbb73a2 100644 (file)
@@ -35,7 +35,6 @@ struct xcopy_op {
        unsigned short stdi;
        unsigned short dtdi;
        unsigned short nolb;
-       unsigned int dbl;
 
        struct xcopy_pt_cmd *src_pt_cmd;
        struct xcopy_pt_cmd *dst_pt_cmd;