PCI/VPD: Remove sysfs accessor size checking dead code
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 3 Feb 2021 08:48:03 +0000 (09:48 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 30 Mar 2021 21:50:42 +0000 (16:50 -0500)
Since 104daa71b396 ("PCI: Determine actual VPD size on first access")
attribute size is set to 0 (unlimited).

Remove the dead code that checks for "bin_attr->size > 0".

Link: https://lore.kernel.org/r/267eae86-f8a6-6792-a7f8-2c4fd51beedc@gmail.com
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Krzysztof WilczyƄski <kw@linux.com>
drivers/pci/vpd.c

index ef5165eb3b624ee5bf07d1ec6b937d9a5d7046f2..ab81c7a5185f69bc532c99b5e1e1aea81a9f4927 100644 (file)
@@ -403,13 +403,6 @@ static ssize_t read_vpd_attr(struct file *filp, struct kobject *kobj,
 {
        struct pci_dev *dev = to_pci_dev(kobj_to_dev(kobj));
 
-       if (bin_attr->size > 0) {
-               if (off > bin_attr->size)
-                       count = 0;
-               else if (count > bin_attr->size - off)
-                       count = bin_attr->size - off;
-       }
-
        return pci_read_vpd(dev, off, count, buf);
 }
 
@@ -419,13 +412,6 @@ static ssize_t write_vpd_attr(struct file *filp, struct kobject *kobj,
 {
        struct pci_dev *dev = to_pci_dev(kobj_to_dev(kobj));
 
-       if (bin_attr->size > 0) {
-               if (off > bin_attr->size)
-                       count = 0;
-               else if (count > bin_attr->size - off)
-                       count = bin_attr->size - off;
-       }
-
        return pci_write_vpd(dev, off, count, buf);
 }