drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.0/7
authorEvan Quan <evan.quan@amd.com>
Thu, 2 Jun 2022 03:34:10 +0000 (11:34 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 8 Jun 2022 15:43:35 +0000 (11:43 -0400)
PMFW will handle that properly. Driver involvement may cause some
unexpected issues.

Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c

index ae595ee544dcad15a74f5fc2dd673b0c15df6257..fb04d82f66e63b7e343b7ae844ed068d22e876eb 100644 (file)
@@ -1407,6 +1407,18 @@ static int smu_disable_dpms(struct smu_context *smu)
                  (amdgpu_asic_reset_method(adev) == AMD_RESET_METHOD_BACO)) ||
                 ((adev->in_runpm || adev->in_s4) && amdgpu_asic_supports_baco(adev)));
 
+       /*
+        * For SMU 13.0.0 and 13.0.7, PMFW will handle the DPM features(disablement or others)
+        * properly on suspend/reset/unload. Driver involvement may cause some unexpected issues.
+        */
+       switch (adev->ip_versions[MP1_HWIP][0]) {
+       case IP_VERSION(13, 0, 0):
+       case IP_VERSION(13, 0, 7):
+               return 0;
+       default:
+               break;
+       }
+
        /*
         * For custom pptable uploading, skip the DPM features
         * disable process on Navi1x ASICs.
@@ -1444,7 +1456,6 @@ static int smu_disable_dpms(struct smu_context *smu)
                case IP_VERSION(11, 0, 0):
                case IP_VERSION(11, 0, 5):
                case IP_VERSION(11, 0, 9):
-               case IP_VERSION(13, 0, 0):
                        return 0;
                default:
                        break;