media: i2c: tvp5150: check return value of devm_kasprintf()
authorClaudiu Beznea <claudiu.beznea@microchip.com>
Thu, 15 Jun 2023 10:30:30 +0000 (12:30 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 14 Jul 2023 11:08:14 +0000 (13:08 +0200)
devm_kasprintf() returns a pointer to dynamically allocated memory.
Pointer could be NULL in case allocation fails. Check pointer validity.
Identified with coccinelle (kmerr.cocci script).

Fixes: 0556f1d580d4 ("media: tvp5150: add input source selection of_graph support")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/tvp5150.c

index c7fb35ee3f9de748c88f69c407930dbbed549949..e543b3f7a4d89bb71ea8d1bc2df3a8e4c878834f 100644 (file)
@@ -2068,6 +2068,10 @@ static int tvp5150_parse_dt(struct tvp5150 *decoder, struct device_node *np)
                tvpc->ent.name = devm_kasprintf(dev, GFP_KERNEL, "%s %s",
                                                v4l2c->name, v4l2c->label ?
                                                v4l2c->label : "");
+               if (!tvpc->ent.name) {
+                       ret = -ENOMEM;
+                       goto err_free;
+               }
        }
 
        ep_np = of_graph_get_endpoint_by_regs(np, TVP5150_PAD_VID_OUT, 0);