staging: vt6655: Type encoding info dropped from variable name "wBeaconInterval"
authorPavan Bobba <opensource206@gmail.com>
Tue, 31 Oct 2023 05:34:28 +0000 (11:04 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Nov 2023 12:47:41 +0000 (12:47 +0000)
variable name "wBeaconInterval" updated like below:

a.type encoding info dropped from name
b.camelcase name replaced by snakecase

Issue found by checkpatch

Signed-off-by: Pavan Bobba <opensource206@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/a8aa6227fb8dadfdebb0a6ab74cff9730358c765.1698730318.git.opensource206@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/card.c
drivers/staging/vt6655/card.h
drivers/staging/vt6655/device.h

index bfd02a869d646cf1558e606a4838418ab0767412..c18cbf0aad75467832f0ed76f293690550623896 100644 (file)
@@ -314,24 +314,24 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
  * Parameters:
  *  In:
  *      priv         - The adapter to be set.
- *      wBeaconInterval - Beacon Interval
+ *      beacon_interval - Beacon Interval
  *  Out:
  *      none
  *
  * Return Value: true if succeed; otherwise false
  */
 bool card_set_beacon_period(struct vnt_private *priv,
-                         unsigned short wBeaconInterval)
+                         unsigned short beacon_interval)
 {
        u64 qwNextTBTT;
 
        qwNextTBTT = vt6655_get_current_tsf(priv); /* Get Local TSF counter */
 
-       qwNextTBTT = CARDqGetNextTBTT(qwNextTBTT, wBeaconInterval);
+       qwNextTBTT = CARDqGetNextTBTT(qwNextTBTT, beacon_interval);
 
        /* set HW beacon interval */
-       iowrite16(wBeaconInterval, priv->port_offset + MAC_REG_BI);
-       priv->wBeaconInterval = wBeaconInterval;
+       iowrite16(beacon_interval, priv->port_offset + MAC_REG_BI);
+       priv->beacon_interval = beacon_interval;
        /* Set NextTBTT */
        qwNextTBTT =  le64_to_cpu(qwNextTBTT);
        iowrite32((u32)qwNextTBTT, priv->port_offset + MAC_REG_NEXTTBTT);
@@ -764,11 +764,11 @@ u64 vt6655_get_current_tsf(struct vnt_private *priv)
  *
  * Return Value: TSF value of next Beacon
  */
-u64 CARDqGetNextTBTT(u64 qwTSF, unsigned short wBeaconInterval)
+u64 CARDqGetNextTBTT(u64 qwTSF, unsigned short beacon_interval)
 {
        u32 beacon_int;
 
-       beacon_int = wBeaconInterval * 1024;
+       beacon_int = beacon_interval * 1024;
        if (beacon_int) {
                do_div(qwTSF, beacon_int);
                qwTSF += 1;
@@ -785,21 +785,21 @@ u64 CARDqGetNextTBTT(u64 qwTSF, unsigned short wBeaconInterval)
  * Parameters:
  *  In:
  *      iobase          - IO Base
- *      wBeaconInterval - Beacon Interval
+ *      beacon_interval - Beacon Interval
  *  Out:
  *      none
  *
  * Return Value: none
  */
 void CARDvSetFirstNextTBTT(struct vnt_private *priv,
-                          unsigned short wBeaconInterval)
+                          unsigned short beacon_interval)
 {
        void __iomem *iobase = priv->port_offset;
        u64 qwNextTBTT;
 
        qwNextTBTT = vt6655_get_current_tsf(priv); /* Get Local TSF counter */
 
-       qwNextTBTT = CARDqGetNextTBTT(qwNextTBTT, wBeaconInterval);
+       qwNextTBTT = CARDqGetNextTBTT(qwNextTBTT, beacon_interval);
        /* Set NextTBTT */
        qwNextTBTT =  le64_to_cpu(qwNextTBTT);
        iowrite32((u32)qwNextTBTT, iobase + MAC_REG_NEXTTBTT);
@@ -815,18 +815,18 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv,
  *  In:
  *      priv         - The adapter to be set
  *      qwTSF           - Current TSF counter
- *      wBeaconInterval - Beacon Interval
+ *      beacon_interval - Beacon Interval
  *  Out:
  *      none
  *
  * Return Value: none
  */
 void CARDvUpdateNextTBTT(struct vnt_private *priv, u64 qwTSF,
-                        unsigned short wBeaconInterval)
+                        unsigned short beacon_interval)
 {
        void __iomem *iobase = priv->port_offset;
 
-       qwTSF = CARDqGetNextTBTT(qwTSF, wBeaconInterval);
+       qwTSF = CARDqGetNextTBTT(qwTSF, beacon_interval);
        /* Set NextTBTT */
        qwTSF =  le64_to_cpu(qwTSF);
        iowrite32((u32)qwTSF, iobase + MAC_REG_NEXTTBTT);
index f84e4190a2ac4d88adf669cc81153f4669454114..1758a95f3ab072e98f2adfb09eab45739a725efb 100644 (file)
@@ -43,11 +43,11 @@ void card_set_rspinf(struct vnt_private *priv, u8 bb_type);
 void CARDvUpdateBasicTopRate(struct vnt_private *priv);
 bool CARDbIsOFDMinBasicRate(struct vnt_private *priv);
 void CARDvSetFirstNextTBTT(struct vnt_private *priv,
-                          unsigned short wBeaconInterval);
+                          unsigned short beacon_interval);
 void CARDvUpdateNextTBTT(struct vnt_private *priv, u64 qwTSF,
-                        unsigned short wBeaconInterval);
+                        unsigned short beacon_interval);
 u64 vt6655_get_current_tsf(struct vnt_private *priv);
-u64 CARDqGetNextTBTT(u64 qwTSF, unsigned short wBeaconInterval);
+u64 CARDqGetNextTBTT(u64 qwTSF, unsigned short beacon_interval);
 u64 card_get_tsf_offset(unsigned char rx_rate, u64 qwTSF1, u64 qwTSF2);
 unsigned char card_get_pkt_type(struct vnt_private *priv);
 void CARDvSafeResetTx(struct vnt_private *priv);
@@ -57,6 +57,6 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type);
 bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
                    u64 bss_timestamp);
 bool card_set_beacon_period(struct vnt_private *priv,
-                         unsigned short wBeaconInterval);
+                         unsigned short beacon_interval);
 
 #endif /* __CARD_H__ */
index d9ee0b7401fe063eacccda6b8c2c68503c027525..fadbfccf42de32c684efcc03ababa11eea680691 100644 (file)
@@ -281,7 +281,7 @@ struct vnt_private {
 
        unsigned char abyEEPROM[EEP_MAX_CONTEXT_SIZE]; /* unsigned long alignment */
 
-       unsigned short wBeaconInterval;
+       unsigned short beacon_interval;
        u16 wake_up_count;
 
        struct work_struct interrupt_work;