um: vector: Fix memory leak in vector_config
authorXiang Yang <xiangyang3@huawei.com>
Tue, 15 Nov 2022 07:32:25 +0000 (15:32 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 12:57:23 +0000 (13:57 +0100)
[ Upstream commit 8f88c73afe481f93d40801596927e8c0047b6d96 ]

If the return value of the uml_parse_vector_ifspec function is NULL,
we should call kfree(params) to prevent memory leak.

Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver")
Signed-off-by: Xiang Yang <xiangyang3@huawei.com>
Acked-By: Anton Ivanov <anton.ivanov@kot-begemot.co.uk>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/um/drivers/vector_kern.c

index cde6db184c26b4601ac339afda94a287d3b9313f..45a4bcd27a39b018eca0441783f483c26df8824b 100644 (file)
@@ -770,6 +770,7 @@ static int vector_config(char *str, char **error_out)
 
        if (parsed == NULL) {
                *error_out = "vector_config failed to parse parameters";
+               kfree(params);
                return -EINVAL;
        }