hwmon: tmp513: Simplify tmp51x_read_properties()
authorBiju Das <biju.das.jz@bp.renesas.com>
Thu, 7 Sep 2023 07:14:04 +0000 (08:14 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Fri, 27 Oct 2023 14:27:23 +0000 (07:27 -0700)
Simplify tmp51x_read_properties() by replacing 'nfactor' ->'data->nfactor'
in device_property_read_u32_array() and drop the local variable as it is
unused.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230907071404.24334-3-biju.das.jz@bp.renesas.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/tmp513.c

index b336b95298ab3bd89004bec84a3c0c4f0ae61cb8..8a7cf08733c64293c0af5dafb0b97187db3c3dd5 100644 (file)
@@ -653,7 +653,6 @@ static int tmp51x_pga_gain_to_reg(struct device *dev, struct tmp51x_data *data)
 static int tmp51x_read_properties(struct device *dev, struct tmp51x_data *data)
 {
        int ret;
-       u32 nfactor[3];
        u32 val;
 
        ret = device_property_read_u32(dev, "shunt-resistor-micro-ohms", &val);
@@ -671,10 +670,8 @@ static int tmp51x_read_properties(struct device *dev, struct tmp51x_data *data)
        if (ret < 0)
                return ret;
 
-       ret = device_property_read_u32_array(dev, "ti,nfactor", nfactor,
-                                           data->max_channels - 1);
-       if (ret >= 0)
-               memcpy(data->nfactor, nfactor, data->max_channels - 1);
+       device_property_read_u32_array(dev, "ti,nfactor", data->nfactor,
+                                      data->max_channels - 1);
 
        // Check if shunt value is compatible with pga-gain
        if (data->shunt_uohms > data->pga_gain * 40 * 1000 * 1000) {